-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Exit Codes #42
Conversation
Return 1 for issues found, 0 for safe
The CLI exit status codes are: - `0`: Scan completed successfully, no vulnerabilities found - `1`: Scan completed successfully, vulnerabilities found - `2`: Scan failed, modelscan threw an error while scanning - `3`: No supported files were passed to the tool - `4`: Usage error, CLI was passed invalid or incomplete options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments, otherwise looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, just one small formatting comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Update the exit status codes to:
0
: Scan completed successfully, no vulnerabilities found1
: Scan completed successfully, vulnerabilities found2
: Scan failed, modelscan threw an error while scanning3
: No supported files were passed to the tool4
: Usage error, CLI was passed invalid or incomplete optionsresolves issue #41