Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues handling zip files in ModelScan._iterate_models() #219

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mmaitre314
Copy link
Contributor

Fix for #215:

  • Handle exceptions when trying to scan password-protected zip files
  • Handle zip files irrespective of extensions
  • Add test

Copy link
Member

@iamfaisalkhan iamfaisalkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking this up.

@seanpmorgan seanpmorgan merged commit 024100c into protectai:main Nov 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants