Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested Zip Handling #106

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Nested Zip Handling #106

merged 5 commits into from
Feb 20, 2024

Conversation

swashko
Copy link
Collaborator

@swashko swashko commented Feb 12, 2024 •
edited
Loading

Adds an error to the results if a zip file scanned contains another zip file that is not scanned by any existing scanners.

Expected behavior:

  • Zip file contains a keras file: zip will be unzipped, keras will be scanned, no error
  • Zip file contains a new pytorch file or other zip file: zip will be unzipped, inner zip or pytorch will be attempted to be scanned with no results, ModelScan error is added to results that nested zips are not supported

@swashko swashko self-assigned this Feb 12, 2024
seanpmorgan
seanpmorgan approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanpmorgan seanpmorgan merged commit 5a6e5dd into main Feb 20, 2024
8 checks passed
@seanpmorgan seanpmorgan deleted the nested-zip branch February 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@iamfaisalkhan iamfaisalkhan Awaiting requested review from iamfaisalkhan

@mehrinkiani mehrinkiani Awaiting requested review from mehrinkiani

Assignees

@swashko swashko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swashko @seanpmorgan