-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pytest-mpl image comparison tests and update CI workflow #413
Open
lukelbd
wants to merge
10
commits into
master
Choose a base branch
from
add-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukelbd
commented
Mar 27, 2023
lukelbd
force-pushed
the
add-tests
branch
4 times, most recently
from
March 29, 2023 09:37
5bdb427
to
17a8bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will finally add robust image comparison testing to proplot using matplotlib/pytest-mpl.
Inside
tests
, I declare several functions developed from my own ad hoc jupyter notebook tests. These will be automatically detected + run bypytest
, with image comparisons carried out bypytest-mpl
. Further, insidetests/test_docs.py
, I dynamically create testing functions from the rst-style python files indocs
usingjupytext
, so thatpytest-mpl
can perform image comparisons on the documentation examples alongside the other testing files. So, the travis CI no longer compiles the documentation withmake html
-- instead, the existing readthedocs workflow does this, and it should also now be enabled for new pull requests (if not, will try to figure out soon). I also use a fork ofpytest-mpl
to support comparing arbitrary figures created by each testing function (i.e., without explicitly returning figure objects; see this branch).This work was done quite a while ago -- has just been sitting on my machine. Would like to merge it this spring.