Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont check bool dtype until after ndarray conversion #412

Closed

Conversation

scottstanie
Copy link
Contributor

This appears to fix #411

In [1]: import proplot as pplt
import numpy as np

In [2]: import numpy as np

In [3]: fig, ax = pplt.subplot()
   ...: ax.plot(np.arange(10))
Out[3]: <a list of 1 Line2D objects>

@syrte Feel free to check on this if you have other

@lukelbd
Copy link
Collaborator

lukelbd commented Mar 26, 2023

Sorry, awkward timing -- just submitted a fix myself (see issue thread). Appreciate the contribution though.

And thanks for the test. I am currently working on adding lots of unit tests to the CI workflow; will add your function to these.

@lukelbd lukelbd closed this Mar 26, 2023
@lukelbd lukelbd added the bug label Mar 26, 2023
@scottstanie
Copy link
Contributor Author

oh great, no problem! that timing was so exact that it confused me how my branch suddenly had merge conflicts haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: error with the latest dev version AttributeError: 'list' object has no attribute 'dtype'
2 participants