Improve shared axis label algorithm #385
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is, for complex layouts such as the one below,
proplot
screws up shared axes labels positions.In the above case,
LABEL1
occupies the entire column even though the second group of plots might have its own shared and different label axis. The patch addresses this case and checks whether label text is the same across subject axes.Further work is needed in this direction to develop a definitive policy regarding axes label grouping.