Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shared axis label algorithm #385

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pulkin
Copy link

@pulkin pulkin commented Sep 3, 2022

The issue is, for complex layouts such as the one below, proplot screws up shared axes labels positions.

   1111111
L  1111111
A
B  1111111
E  1111111
L
1  222 222
   222 222
   222 222

In the above case, LABEL1 occupies the entire column even though the second group of plots might have its own shared and different label axis. The patch addresses this case and checks whether label text is the same across subject axes.

Further work is needed in this direction to develop a definitive policy regarding axes label grouping.

@lukelbd lukelbd changed the title Work around #384 Improve shared axis label algorithm Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants