Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit sharing y-labels on the right spine, x-labels on the top spine #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lukelbd
Copy link
Collaborator

@lukelbd lukelbd commented Jun 3, 2020

This PR will expand the axis-sharing feature so that it works with tick labels on the left, right, bottom or top spines, not just the left/bottom spines. Figure(..., sharex=sharex) will share groups of x-axes whose tick labels are on the bottom or top with the bottommost and topmost subplots (respectively), and Figure(..., sharey=sharey) will share labels from groups of y-axes whose tick labels are on the left or right with the leftmost and rightmost subplots (respectively). This will address #205.

This will also allow me to tackle #79 (and #178). It is much more common to need longitude/latitude labels on the right and top spines for geographic projections than for Cartesian projections (e.g. this Lambert conformal example requires labels on the top spine for the 60 degree and 80 degree latitude lines, because they don't intersect any other spine). This is a major reason reason I had not tried to implement "axis sharing" for geographic plots yet.

Just wanted to open a PR because it's one of the more important changes to proplot needed before v1. May not have a chance to tackle it for several months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant