Fix broken test

proofcarryingdata · Sep 9, 2024 · 19b8d04 · 19b8d04
1 parent 1f531d0
commit 19b8d04
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 2 deletions.
diff --git a/examples/test-app/tsconfig.json b/examples/test-app/tsconfig.json
@@ -7,6 +7,7 @@
     "module": "ES2020",
     "moduleResolution": "Bundler",
     "esModuleInterop": true,
+    "strict": true,
     "sourceMap": true
   },
   "include": ["**/*.ts", "**/*.tsx"],

diff --git a/packages/podspec/src/parse/entries.ts b/packages/podspec/src/parse/entries.ts
@@ -63,6 +63,31 @@ export interface EntriesParseOptions<E extends EntriesSchema> {
   tuples?: EntriesTupleSchema<E>[];
 }
 
+const VALID_ENTRY_SCHEMA_TYPES = [
+  "int",
+  "string",
+  "cryptographic",
+  "eddsa_pubkey",
+  "optional"
+] as const;
+
+type ValidEntrySchemaType = (typeof VALID_ENTRY_SCHEMA_TYPES)[number];
+
+// Type assertion to ensure ValidEntrySchemaType matches EntrySchema["type"]
+type AssertEntrySchemaType = ValidEntrySchemaType extends EntrySchema["type"]
+  ? EntrySchema["type"] extends ValidEntrySchemaType
+    ? true
+    : false
+  : false;
+
+// This will cause a compile-time error if the types don't match
+const _: AssertEntrySchemaType = true;
+
+// Runtime check function
+function isValidEntryType(type: string): type is EntrySchema["type"] {
+  return (VALID_ENTRY_SCHEMA_TYPES as readonly string[]).includes(type);
+}
+
 /**
  * A specification for a set of entries.
  */
@@ -72,7 +97,17 @@ export class EntriesSpec<E extends EntriesSchema> {
    *
    * @param schema The schema to use for this set of entries.
    */
-  private constructor(public readonly schema: E) {}
+  private constructor(public readonly schema: E) {
+    for (const [name, entry] of Object.entries(schema)) {
+      const entryType =
+        entry.type === "optional" ? entry.innerType.type : entry.type;
+      if (!isValidEntryType(entryType)) {
+        throw new Error(
+          `Entry ${name} contains invalid entry type: ${entryType as string}`
+        );
+      }
+    }
+  }
 
   /**
    * Parse entries without throwing an exception.

diff --git a/packages/podspec/test/podspec.spec.ts b/packages/podspec/test/podspec.spec.ts
@@ -35,7 +35,6 @@ function generateRandomHex(byteLength: number): string {
 function generateKeyPair(): { privateKey: string; publicKey: string } {
   const privateKey = generateRandomHex(32);
   const publicKey = encodePublicKey(
-    // eslint-disable-next-line @typescript-eslint/no-unsafe-call
     derivePublicKey(decodePrivateKey(privateKey))
   );
   return { privateKey, publicKey };