Add auto save and restore for config options #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bulletmark
force-pushed
the
options-saver
branch
from
52dffe1
to
f8139ba
Compare
|
Thanks, I'll look into this soon. Maybe I'll end up cherry-picking changes from here. This is a great start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #232 and #339. Seems very odd to a new user that ptpython does not save the options the user sets via the nice F2 menu so this PR adds that feature.
The
ptpythonsettings are saved at~/.config/config.jsonand theptipythonsettings are saved at~/.config/ipython-config.json. Only settings that are different from default are saved and the values are pruned each time to ensure that any old config values are removed. Anyconfig.py, if present, re-defines the user's default.I've been careful in the way I have designed this change and to keep it very generic so please ask questions here if you think something looks odd.