Add cisco IMC MIBs

[ranmalka]

Cisco IMC MIBS to monitor Cisco CUCS server IMC (parallel to HPE-ILO)

@SuperQ
@bastischubert
@RichiH
Signed-off-by: ran [email protected]

[ranmalka]

@bastischubert I reduced it to 3 metrics instead of 3000 lines, hope its ok now

[ranmalka]

I would like to get your approval :)
@bastischubert @SuperQ

Thanks,

[bastischubert]

@ranmalka have you checked my last comments? after that i think we're ready to merge

[ranmalka]

@ranmalka have you checked my last comments? after that i think we're ready to merge

@bastischubert do you mean to put the files directly in the mibs location? so yes that's what I did

[bastischubert]

@ranmalka i left a few comments that still need to be adressed with the Makefile

[ranmalka]

@bastischubert conflicts have been fixed :)

[bastischubert]

@ranmalka did you notice the comments i left and are still not yet addressed ? https://github.com/prometheus/snmp_exporter/pull/1293/files you should see them there.

• i asked why you added the CISCO_FRU_URL which seems unused.
• $(MIBDIR)/cisco_imc to $(MIBDIR)/.cisco_imc still needs to be addressed

everything else already looks good and ready to get merged 👍

[ranmalka]

@bastischubert CISCO_FRU_URL used by 1.3.6.1.4.1.9.9.719.1.1.1.1.11 it didn't work before that

why do I need to add .cisco_imc folder? I added all the mibs files into the /mibs directory

[bastischubert]

@ranmalka

CISCO_FRU_URL used by 1.3.6.1.4.1.9.9.719.1.1.1.1.11 it didn't work before that

i checked, you only need those 4 mibs to get config working:
CISCO-UNIFIED-COMPUTING-FAULT-MIB.my
CISCO-UNIFIED-COMPUTING-MIB.my
CISCO-UNIFIED-COMPUTING-STORAGE-MIB.my
CISCO-UNIFIED-COMPUTING-TC-MIB.my

why do I need to add .cisco_imc folder? I added all the mibs files into the /mibs directory

basically to prevent the download on every run of make mibs - plus putting that marker in a hidden file instead of a directory.

[ranmalka]

@bastischubert

CISCO_FRU_URL used by 1.3.6.1.4.1.9.9.719.1.1.1.1.11 it didn't work before that

i checked, you only need those 4 mibs to get config working: CISCO-UNIFIED-COMPUTING-FAULT-MIB.my CISCO-UNIFIED-COMPUTING-MIB.my CISCO-UNIFIED-COMPUTING-STORAGE-MIB.my CISCO-UNIFIED-COMPUTING-TC-MIB.my

I also added cisco-TCI and CISCO-SMI to your list, looks fine (tests passed)

basically to prevent the download on every run of make mibs - plus putting that marker in a hidden file instead of a directory.

Now is that ok?

let me know what else is needed

[bastischubert]

LGTM

[bastischubert]

@ranmalka thanks for your patience and your contribution 🚀