Update to yaml.v3 #166
Open
Update to yaml.v3 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the upside of moving to V3? |
|
Better, somehow, maintained and homogeneity with other prometheus projects. |
|
can we get some traction on this one? |
|
prometheus/prometheus is still using yaml.v2 |
mikelolasagasti
force-pushed
the
yamlv3
branch
from
d4f4c75
to
a1826e7
Compare
Also, modify `empty_config_yml` because with yaml.v3 reading empty file causes Decode to return EOF error, as described in go-yaml/yaml#805 issue. Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
mikelolasagasti
force-pushed
the
yamlv3
branch
from
a1826e7
to
d3e814e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, modify
empty_config_ymlbecause with yaml.v3 reading empty file causes Decode to return EOF error, as described in go-yaml/yaml#805 issue.