Use functools.wraps instead of decorator #766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury Pliner <[email protected]>
python/mypy#1927 Signed-off-by: Yury Pliner <[email protected]>
Signed-off-by: Yury Pliner <[email protected]>
Pliner
commented
Feb 8, 2022
|
|
||
| return decorate(f, wrapped) | ||
| return f(*args, **kwargs) | ||
| return wrapped # type: ignore |
There was a problem hiding this comment.
It looks like there are two options for now: ignore or cast.
PS In python 3.10 it was resolved via https://docs.python.org/3/library/typing.html#typing.ParamSpec.
|
@csmarchbanks Could you look on it please? Thanks. |
Pliner
commented
Feb 8, 2022
| @@ -54,7 +54,7 @@ def f(r): | |||
| else: | |||
| raise TypeError | |||
|
|
|||
| self.assertEqual((["r"], None, None, None), getargspec(f)) | |||
| self.assertEqual("(r)", str(inspect.signature(f))) | |||
There was a problem hiding this comment.
I'm not sure these checks are relevant now: it could be worth ditching them.
Signed-off-by: Yury Pliner <[email protected]>
Pliner
force-pushed
the
use-functools-wraps-instead-of-decorator
branch
from
551660d
to
fe2a233
Compare
Signed-off-by: Yury Pliner <[email protected]>
csmarchbanks
reviewed
Feb 8, 2022
There was a problem hiding this comment.
Hmm, I am not super familiar with functools.wraps but I see some disagreement around if it actually preserves the signature, for example: https://stackoverflow.com/questions/13907644/decorator-module-vs-functools-wraps/55363013#55363013. Are there some recent posts around functools.wraps for 3.6+ that fully preserve the signature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small cleanup: only 3.6+ is supported, so it looks fine to switch to
functools.wraps.