Add timeout option for webhook notifier. #4137
Open
+65
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesg
force-pushed
the
webhook-timeout
branch
from
51812ee
to
fb57eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have witnessed cases where POST requests hang, because the receiver has become temporarily unresponsive, leading to failed notification attempts. If the request times out before the dispatcher timeout, because of some aspect of how the HTTP client is configured, then the request is retried, but this does not happen reliably.
To cover all eventualities, it makes sense to have a shorter per-request timeout. I think this timeout needs to be opt-in from the user perspective, as it requires prior knowledge of how fast the webhook should respond, and that it could lead to duplicate notifications.