sdk v2: Set RetryMaxAttempts on root config instead client options #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgeckhart
commented
Aug 21, 2023
Comment on lines
+277
to
281
|
|
||
| // Setting an explicit retryer will override the default settings on the config | ||
| options.Retryer = retry.NewStandard(func(options *retry.StandardOptions) { | ||
| options.MaxAttempts = 5 | ||
| options.MaxBackoff = 3 * time.Second |
There was a problem hiding this comment.
I believe this is not impacted by the upstream bug since it's using Retryer instead of RetryMaxAttempts but it's really hard to test if that's true.
cristiangreco
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have noticed that when using the various client
options.RetryMaxAttemptsit doesn't set the retry max attempts and the default of 3 retries is still being used. I opened a bug about this upstream, aws/aws-sdk-go-v2#2251, but for now setting the retry value at the root config has worked as expected.