Use worker pool for smartctl #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…theus-community#197). Signed-off-by: Póka Balázs <[email protected]>
|
@NiceGuyIT could you comment on whether I need to do something else before this PR is likely to be accepted? |
SuperQ
reviewed
Jun 19, 2024
| return | ||
| } | ||
|
|
||
| pool := createPool() |
There was a problem hiding this comment.
This seems to be implementing a sync.WaitGroup. Or maybe better, use errgroup.Group.
There was a problem hiding this comment.
Thanks. Will try to refactor it later, after the fate of #205 is decided.
There was a problem hiding this comment.
Thanks. Will try to refactor it later, after the fate of #205 is decided.
Merged. Can you fix the conflicts for merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use worker pool to make running of smartctl parallel (for issue #197).