Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat add option to run indefinitely #89

Conversation

jmichalek132
Copy link
Contributor

@jmichalek132 jmichalek132 commented Sep 27, 2024

For long running load tests, it would be good if we could keep it running indefinitely. WDYT @bwplotka .

@jmichalek132 jmichalek132 force-pushed the jm-feat-add-option-to-run-indefinitely branch from 018dc83 to a45c05e Compare September 27, 2024 13:01
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small nit!

Thanks!

metrics/write.go Outdated Show resolved Hide resolved
jmichalek132 and others added 3 commits September 27, 2024 15:48
Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Juraj Michálek <[email protected]>
Signed-off-by: Juraj Michalek <[email protected]>
@bwplotka
Copy link
Member

Proposed improvement on top (my suggestion was not ideal) #90

@jmichalek132
Copy link
Contributor Author

Closing in favor of cleaner approach in #90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants