Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrency limit for remote write #46

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Add concurrency limit for remote write #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/avalanche/avalanche.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ func main() {
// TODO(bwplotka): Kill pprof feature, you can install OSS continuous profiling easily instead.
remotePprofURLs := kingpin.Flag("remote-pprof-urls", "a list of urls to download pprofs during the remote write: --remote-pprof-urls=http://127.0.0.1:10902/debug/pprof/heap --remote-pprof-urls=http://127.0.0.1:10902/debug/pprof/profile").URLList()
remotePprofInterval := kingpin.Flag("remote-pprof-interval", "how often to download pprof profiles. When not provided it will download a profile once before the end of the test.").Duration()
remoteConcurrencyLimit := kingpin.Flag("remote-concurrency-limit", "how many concurrent writes can happen at any given time").Default("20").Int()
remoteBatchSize := kingpin.Flag("remote-batch-size", "how many samples to send with each remote_write API request.").Default("2000").Int()
remoteRequestCount := kingpin.Flag("remote-requests-count", "How many requests to send in total to the remote_write API. Set to -1 to run indefinitely.").Default("100").Int()
remoteReqsInterval := kingpin.Flag("remote-write-interval", "delay between each remote write request.").Default("100ms").Duration()
Expand Down Expand Up @@ -106,6 +107,7 @@ func main() {
BatchSize: *remoteBatchSize,
RequestCount: *remoteRequestCount,
UpdateNotify: collector.UpdateNotifyCh(),
Concurrency: *remoteConcurrencyLimit,
Tenant: *remoteTenant,
TLSClientConfig: tls.Config{
InsecureSkipVerify: *tlsClientInsecure,
Expand Down
7 changes: 7 additions & 0 deletions metrics/write.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ type ConfigWrite struct {
TLSClientConfig tls.Config
TenantHeader string
OutOfOrder bool
Concurrency int
}

// Client for the remote write requests.
Expand Down Expand Up @@ -144,6 +145,8 @@ func (c *Client) write(ctx context.Context) error {
ticker := time.NewTicker(c.config.RequestInterval)
defer ticker.Stop()

concurrencyLimitCh := make(chan struct{}, c.config.Concurrency)

for i := 0; ; {
if ctx.Err() != nil {
return ctx.Err()
Expand Down Expand Up @@ -180,7 +183,11 @@ func (c *Client) write(ctx context.Context) error {
start := time.Now()
for i := 0; i < len(tss); i += c.config.BatchSize {
wgMetrics.Add(1)
concurrencyLimitCh <- struct{}{}
go func(i int) {
defer func() {
<-concurrencyLimitCh
}()
defer wgMetrics.Done()
end := i + c.config.BatchSize
if end > len(tss) {
Expand Down
Loading