Log remote write errors as they happen #102
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
commented
Oct 18, 2024
Comment on lines
-345
to
-347
| if httpResp.StatusCode/100 == 5 { | ||
| return err | ||
| } |
There was a problem hiding this comment.
Also removed this block as it seems like the error would be assigned in the previous if block anyway on 5xx? Can add back in if I'm wrong somewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows logging remote write errors as they happen instead of waiting till the end of 20*refreshInterval. The motivation is to allow catching config issues early during ad-hoc benchmarking.
Addresses #81