Skip to content

Commit

Permalink
Change default for --metric-interval to 0 (breaking change)
Browse files Browse the repository at this point in the history
See related discussion: #97 (comment)

> I think we should move this default to zero. Essentially I don't see real case of changing metric names in any application. Metric names are generally stable AFAIK, do you know any cases where that's not true? Are they often?


cc @jmichalek132 

Signed-off-by: Bartlomiej Plotka <[email protected]>
  • Loading branch information
bwplotka authored Oct 9, 2024
1 parent 30168ac commit ac43a30
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion metrics/serve.go
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func NewConfigFromFlags(flagReg func(name, help string) *kingpin.FlagClause) *Co
IntVar(&cfg.ValueInterval)
flagReg("series-interval", "Change series_id label values every {interval} seconds. 0 means no change.").Default("60").
IntVar(&cfg.SeriesInterval)
flagReg("metric-interval", "Change __name__ label values every {interval} seconds. 0 means no change.").Default("120").
flagReg("metric-interval", "Change __name__ label values every {interval} seconds. 0 means no change.").Default("0").
IntVar(&cfg.MetricInterval)
flagReg("series-change-interval", "Change the number of series every {interval} seconds. Applies to 'gradual-change', 'double-halve' and 'spike' modes. 0 means no change.").Default("30").
IntVar(&cfg.SeriesChangeInterval)
Expand Down

0 comments on commit ac43a30

Please sign in to comment.