feat: improve systemd.service #223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is moot: since 2018, Golang defaults to nproc. Signed-off-by: Antoine Beaupré <[email protected]>
Signed-off-by: Antoine Beaupré <[email protected]>
Taken from the Debian package. Signed-off-by: Antoine Beaupré <[email protected]>
Restart=always and on-failure can have dramatic consequences in certain cases, for example on-failure will repeatedly restart Prometheus on a configuration error, filling the disk and "always" will ignore attempts to stop Prometheus from the API. Signed-off-by: Antoine Beaupré <[email protected]>
Signed-off-by: Antoine Beaupré <[email protected]>
Cargo-culted from Debian, but it makes sense that Prometheus should start only after a proper time sync has been achieved, considering how important timestamps are in its architecture. Signed-off-by: Antoine Beaupré <[email protected]>
Signed-off-by: Antoine Beaupré <[email protected]>
anarcat
force-pushed
the
systemd.service
branch
from
e40f5be to
9a85854
Compare
github-actions
bot
added
enhancement
gardar
requested changes
Oct 27, 2023
|
i have tried to keep that change separate, as a standalone commit, to make it easier to review. for me the final change is easier to review as well, but i guess i can also split out the sorting in a separate PR? or do you object to the sorting/regroup as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a sync with the Debian bookworm configuration, but also has a pending fix from https://salsa.debian.org/go-team/packages/prometheus/-/merge_requests/5.
See also #221