Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull out date change code #98

Merged
merged 1 commit into from
May 13, 2024
Merged

Pull out date change code #98

merged 1 commit into from
May 13, 2024

Conversation

lmd59
Copy link
Contributor

@lmd59 lmd59 commented May 9, 2024

Summary

Remove functionality that allows the user to change the date format on review comments.

New behavior

Review comment date is not clickable and stays in the same format. This feature does not seem to have a lot of utility. Removing it fixes an issue with date displays where a review comment card may show the date of another review comment rather than its own. To reproduce this issue on the main branch:

  • Add multiple review comments with dates to a draft artifact, taking note of their correct timestamps
  • Add a review comment on the add tab
  • Immediately switch over to the view tab
  • Some review comments will have incorrect timestamps
  • Timestamps are fixed with reload

Code changes

Remove hover, color change, click response, and date formatter, replaced with simple date display.

Testing guidance

  • 'npm run check:all`
  • Run with npm run start:all
  • Create a draft artifact if necessary
  • Select review option for draft artifact
  • Try to reproduce issue described above (issue should be fixed, and accurate timestamps should be simply displayed)

@elsaperelli elsaperelli self-requested a review May 12, 2024 18:08
@elsaperelli elsaperelli self-assigned this May 12, 2024
Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that we no longer need this functionality. Lgtm!

@elsaperelli elsaperelli merged commit c006c9e into main May 13, 2024
2 checks passed
@elsaperelli elsaperelli deleted the comment-date-fix branch May 13, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants