Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dates according to review spec #97

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

lmd59
Copy link
Contributor

@lmd59 lmd59 commented May 9, 2024

Summary

Update review operation for draft artifacts (other statuses are still being check on) according to the latest spec:

The review operation supports applying an review to an existing artifact, regardless of status. The operation sets the date and lastReviewDate elements of the reviewed artifact, and is otherwise only allowed to create ArtifactAssessment (Basic or cqf-artifactComment extension in R4) resources in the repository.

Because we are working with R4, this means using artifactComments (we already are), but we can still update the logic to set the date and lastReviewDate elements of the reviewed artifact.

New behavior

Creating a new review comment sets the date and lastReviewDate of the artifact.

Code changes

  • Updates to the README description of the review operation
  • Changes to app/src/pages/review/[resourceType]/[id].tsx to allow the creation of a comment to update the date and lastReviewDate

Testing guidance

  • 'npm run check:all`
  • npm run start:all
  • Create a draft artifact if necessary
  • Add a review comment to the draft artifact
  • View the draft artifact json (or in the database with 3T or similar) and check that the date and lastReviewDate have been updated on the artifact

@elsaperelli elsaperelli self-requested a review May 12, 2024 17:33
@elsaperelli elsaperelli self-assigned this May 12, 2024
Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks great! Thank you for implementing this ahead of the Connectathon!

Just two small comments.

app/src/pages/review/[resourceType]/[id].tsx Outdated Show resolved Hide resolved
app/src/pages/review/[resourceType]/[id].tsx Show resolved Hide resolved
@lmd59 lmd59 force-pushed the review-date-update branch from 1aa7139 to 477c827 Compare May 13, 2024 15:24
Update spacing

Co-authored-by: Elsa Perelli <[email protected]>
Copy link
Contributor

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@elsaperelli elsaperelli merged commit 9a361a5 into main May 13, 2024
2 checks passed
@elsaperelli elsaperelli deleted the review-date-update branch May 13, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants