Release draft #58
Release draft #58
Conversation
There was a problem hiding this comment.
Good work! Most of my feedback is related to future tasking and clarifying the spec.
In addition to in-line comments, it might be worth updating the "edit draft resource" tooltip to say something along the lines of "edit/release" since we can't do a release without being on the edit page.
| onClick={() => setIsModalOpen(true)} | ||
| //TODO/question: disabled={} any disable needed? any necessary fields? | ||
| > | ||
| Release |
There was a problem hiding this comment.
This falls out of scope of "release" but interested in your thoughts on this - should we apply the updates to the draft measure automatically instead of having an "update" button? There's some pros/cons of both approaches, but it might be nice to automatically update the artifact content similar to how we automatically re-run calculation in fqm-testify whenever changes are made.
As an example, I made an update to my draft artifact (removed the description) without clicking the "update" button, and then released the artifact. The resulting active artifact had the old description, which could cause issues if someone were to accidentally forget to click the "update" button in practice. If we want to reduce burden on the user, it would be nice to automatically update the artifact
There was a problem hiding this comment.
Ah yes, I also noticed this! I think we should make a task for this. However, in the meantime, do you think it would be useful to at least have some sort of indication that changes have not been saved? So the user knows to update before releasing? Or should we just wait to do this task?
There was a problem hiding this comment.
We can hold off on this for now - I feel like this is a rare case and in general I feel like a user is not likely to make updates and then release directly afterward
app/src/components/ReleaseModal.tsx
Outdated
| body: JSON.stringify(resource) | ||
| }); | ||
|
|
||
| const location = res.headers.get('Location')?.substring(5); // remove 4_0_1 (version) |
There was a problem hiding this comment.
Is there a way that we could generalize this in some way? For our backend service, the location will be 4_0_1/<resource type>/<id>. At future Connectathons we may want to use a public sandbox endpoint instead of localhost, and so I don't think we are guaranteed to have 4_0_1 included in the url. Maybe we could conditionally remove the base version if a base version is present?
There was a problem hiding this comment.
Hopefully the approach I did makes sense for now- we can update in the future when we start using other endpoints.
| }); | ||
|
|
||
| // direct user to published artifact detail page | ||
| router.push(location); |
There was a problem hiding this comment.
Could address this in a follow-up task, but this app is getting pretty slow due to the redirects.
Screenshot below is the logs that I see on the backend. Looks like the data requirements are being calculated automatically, which we expect, but seems like dependent libraries are being found multiple times for the same libraries?
There was a problem hiding this comment.
I agree this needs to be looked at. I think this should be done in a separate task since it looks like this is happening when the user just navigates to an artifact on the publishable measure repository, so it is a bit out of scope for this task.
Co-authored-by: Sarah McDougall <[email protected]>
Co-authored-by: Sarah McDougall <[email protected]>
Co-authored-by: Sarah McDougall <[email protected]>
There was a problem hiding this comment.
I'm running into the following runtime error when I release an artifact:
Looks like the actual release is still successful. I think the issue may be related to the base version handling? Wanted to confirm that you also receive this error before digging deeper.
Summary
This PR adds Release functionality to the Authoring Repository. The user can now "Release" a draft artifact to the central Measure Repository.
New behavior
The user can now "Release" a draft artifact to the central Measure Repository from the Authoring Repository. When a draft artifact is released, the artifact
statuschanges fromdrafttoactive. The spec specifies the following for the Release operation: "To be released, an artifact is required to have a version specified." Therefore, when the user releases a draft, they are prompted to input a version. The draft cannot be released without a version specified. When the user adds a version and confirms the release, the active artifact will now appear in the Measure Repository and the draft artifact will be deleted from the Authoring Repository.Code changes
ReleaseModal.tsx- Modal when the user clicks "Release" to confirm release of the draft artifact and also input for a version.pages/authoring/[resourceType]/[id].tsx- Add modalapp/package.json- add luxonservice/package.json- add corsapp.ts- expose headers using corsTesting guidance
npm run check:allnpm run start:allA few notes/questions for the reviewer:
release_draft_UI) and just did some simple UI.