Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update artifact types to include publishable fields #114

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lmd59
Copy link
Contributor

@lmd59 lmd59 commented Oct 15, 2024

Summary

Create new CRMIRepositoryMeasure and CRMIRepositoryLibrary types that implement CRMIPublishable (in addition to CRMIShareable) according to https://hl7.org/fhir/uv/crmi/StructureDefinition-crmi-publishablemeasure.html and https://hl7.org/fhir/uv/crmi/StructureDefinition-crmi-publishablelibrary.html

New behavior

The date field is now required for a Measure artifact, and both date and type are required for Library. This also required an update to _elements to include required fields.

Code changes

  • Creates CRMIRepository* types on both app and server side and updates all uses of CRMIShareable* to CRMIRepository* across the board.
  • Adds in placeholder dates (and types where applicable) in code and in test structures
  • Update README description of base types
  • Adds date to _elements projection in dbOperations
  • Updates inputUtils to check for date and type as needed

Testing guidance

  • npm run check:all
  • Reset database and load your favorite bundle(s)
  • Use Insomnia to send a create request without a date (should not work).
  • Use front end application, and make sure that functionality remains the same.

Note that date cannot be easily be updated in the front end at the moment. Do we want an additional input field for that? Or we could default it to current date when it's created.
TBD: How do we want to update the capability statement? Particularly, do we want to include a profile on the measure and library resource description, defined as Base System profile for all uses of resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant