generated from projecttacoma/node-fhir-server-ts-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use endpoints #113
Merged
Merged
Use endpoints #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsaperelli
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! All of my comments are just little formatting things, everything looks and works great! HUGE transition!!! 🥳
elsaperelli
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Shifts all front end functionality to use full server operation endpoints rather than local logic with CRUD endpoint interactions.
New behavior
Front end essentially acts the same with a few changes where spec-based operation functionality differs slightly from the original implemented logic.
The review functionality no longer asks whether date should be included and is also enabled for active measures.
Server-side $review and $approve operations now validate artifactAssessmentAuthor (reference) input appropriately according to both GET and POST inputs.
Code changes
Frontend...
dbOperations.ts
,mongodb.ts
, updates.env.example
to remove MONGODB_URI environment variabledraftHelper.ts
,serviceUtils.ts
modifyresourceFields.ts
toversionUtils.ts
to calculate new versionsdraft.ts
andservice.ts
to use server interactions. Note: Future updates could include reorganizingdraft.ts
andservice.ts
to better handle overlapping logic.ReleaseModal.tsx
to remove deletion functionality from release processauthoring/[resourceType]/[id].tsx
to simplify artifact updates and pass modified values to theupdateDraft
procedurereview/[resourceType]/[id].tsx
to change review workflow to use the operation rather than a local update. Enable active artifact reviews and remove date checkboxSmall changes...
ResourceInfoCard.tsx
use consolidated trpc procedurepages/[resourceType].tsx
limit getServersideProps fetch to active onlyauthoring/index.tsx
remove uuid setting since the server creates its own idServer...
requestSchemas.ts
to validate artifactAssessmentAuthor reference as it would be received from either a GET query parameter or a POST FHIR Parameters object. See https://hl7.org/fhir/R4/search.html#reference for more about how a reference is used in query parametersTesting guidance
npm run check:all
npm run build:all
npm run start:all