-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to use CRMI definitions for Measure and Library #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A couple of small recommendations in line as well as recommend replace fhir4.Library
with CRMIShareableLibrary
in app/src/server/trpc/routers/service.ts and app/src/pages/[resourceType]/[id].tsx
Also, I don't know if we necessarily need to, but thought I'd double check if this warrants an update to the service README. There's a lot of mention of Measure
and Library
related support, so do you think it's worth adding a bit about compliance with the CRMI versions of those resources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Summary
This PR updates the typing of Libraries and Measures by using (when possible) CRMIShareableMeasure and CRMIShareableLibrary type definitions.
New behavior
The CRMIShareableMeasure and CRMIShareableLibrary definitions only vary slightly from that of fhir4.Measure and fhir4.Library- they are both extended from them but also require
version
,url
,title
,status
anddescription
.Code changes
fhir4.FhirResource
tofhir4.Measure
andfhir4.Library
toCRMIShareableMeasure
andCRMIShareableLibrary
.url
,version
,title
,description
)Testing guidance
npm run check:all
npm run build:all
npm run start:all