Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoints to $cqfm.package #21

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Update endpoints to $cqfm.package #21

merged 1 commit into from
Nov 17, 2023

Conversation

sarahmcdougall
Copy link
Contributor

Summary

The published version of the measure repository service now specifies $cqfm.package as the endpoint for the package operation. This PR changes instances of $package with $cqfm.package.

New behavior

No new features. Changes the package endpoint, so servers supporting $cqfm.package should now pass package-related tests. Servers that use $package should now fail on package-related tests.

Code changes

Changed instances of $package to $cqfm.package in several files under the lib and spec directories.

Testing guidance

  • Run rspec to run the rspec tests
  • Check that all instances of $package have been changed over
  • Follow the setup instructions in the README to start the test kit. Then run against the locally running measure repository service on the cqfm-package branch. Check that the package-related tests pass. If using the measure repository setup docs for example input values, you may run into some failing tests related to the identifier field. This is unrelated to the package functionality.
    MeasureRepoServiceAndTestKitSetup.pdf

@elsaperelli elsaperelli self-requested a review November 6, 2023 21:39
@elsaperelli elsaperelli self-assigned this Nov 6, 2023
Copy link
Collaborator

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Tested with and without this update.

@hossenlopp hossenlopp merged commit a1ae1a5 into main Nov 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants