Regression cql

[lmd59]

Summary

Updates regression scripts to do an npm install before running so that cql-execution (and other dependencies) can be changed between runs based on the package file.
Adds scripting for pulling from the gitlab coverage-script-bundles and test regression against those formats of packages.

New behavior

No changes to fqm-execution functionality

Code changes

• Update run-regression.sh file to pull coverage-script-bundles from gitlab and npm install before runs
• In regression.ts add findPatientBundlePathsInDirectory for pulling test files out of nested folders, pull some functionality into a shared calculateRegression function, and add functionality for handling and testing against the structure of the coverage-script-bundles directories.

Testing guidance

Create a local branch off of this branch and commit any changes, including a change to the cql-execution version ("cql-execution": "3.0.1",), clone the coverage bundles repo into the regression/bundles directory, then run regression scripts using ./regression/run-regression.sh -b regression-cql -p. (It's important to have the same regression.ts file on both branches that are being compared.)
Note that ecqm content and connectathon repositories will be pulled into the default-bundles folder with the -p flag.

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟢	Statements	85.63%	2455/2867
🟡	Branches	73.41%	2308/3144
🟢	Functions	87.95%	438/498
🟢	Lines	85.91%	2371/2760

Test suite run success

459 tests passing in 31 suites.

Report generated by 🧪jest coverage report action from 6b05441

[cmoesel]

Thank you, @lmd59! No one asked me to review this, but I needed to run a regression anyway, so I took it for a spin.

Everything seems to be working well! The addition of the coverage script bundles is a nice feature, as it appears to add quite a few additional test cases. Excellent!

The one thing I would suggest you consider is making it optional to include the coverage script bundles (maybe enabled by a command line flag). The reasons:

1. The coverage script bundles take a long time. Sometimes a quick regression might be preferred.
2. Anyone using fqm-execution outside of MITRE will not have access to the MITRE GitLab -- so the coverage script bundles will never work for them.

Thanks for this. It will be helpful in the future for feeling more confident about changes to cql-execution.

[lmd59]

Thank you, @lmd59! No one asked me to review this, but I needed to run a regression anyway, so I took it for a spin.

Everything seems to be working well! The addition of the coverage script bundles is a nice feature, as it appears to add quite a few additional test cases. Excellent!

The one thing I would suggest you consider is making it optional to include the coverage script bundles (maybe enabled by a command line flag). The reasons:

1. The coverage script bundles take a long time. Sometimes a quick regression might be preferred.
2. Anyone using fqm-execution outside of MITRE will not have access to the MITRE GitLab -- so the coverage script bundles will never work for them.

Thanks for this. It will be helpful in the future for feeling more confident about changes to cql-execution.

Thanks for the comments @cmoesel - this is a great idea, and I've updated with a command line option to include the internal testing files (default is to not include them). Let me know if you have any other recommendations!

[cmoesel]

Looks good to me! Thank you, @lmd59! That said, I'm new here and wasn't around for discussions about this feature -- so you probably will want a review and approval from someone on the team as well.