Relationship alias coverage fixes #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success459 tests passing in 31 suites. Report generated by 🧪jest coverage report action from 5769ba7 |
…ion alias id in annotation structure, replacing old +1 hack
hossenlopp
force-pushed
the
relationship-alias-coverage-fixes
branch
from
3242601 to
a871fc0
Compare
lmd59
reviewed
Oct 29, 2024
There was a problem hiding this comment.
Love that this fix is working out for us! I added some little comment cleanup suggestions so that you can easily batch most of them, and then a couple of other small suggestions.
We still have a couple of other - 1 and + 1's in the ClauseResultsHelpers file. Do we know if we will have any similar issues with these other alias id's? Might be out of scope for this task, but wanted to bring it up in case we need to create a follow on task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes highlighting of aliases in with/without relationships.
New behavior
Looks in the annotation for the localId that includes the relationship alias so it can be highlighted to match the relationship source.
Also uses the uncoverage work to properly 'not' change the highlighting in coverage when there is a node of the annotation that does not have a result due to its localId not existing in the logic.
Code changes
ClauseResultsHelpers.ts- Added new functionality to find the localId in the annotation that contains the source and alias of relationship clauses. This is then assigned as the alias for the source of the relationship so the alias can be highlighted as covered when the source is covered.HTMLBuilder.ts- Now using the uniquified clauseReuslts results from uncoverage to highlight coverage and allow for annotation nodes that we do not care about (i.e. the ones with localId's only in annotations which we cannot account for in expressions) to not have any styling so they can inherit their parent styling.Testing guidance
Run unit tests and regression scripts to look for changes in coverage. Some changes in coverage and highlighting are to be expected.