Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data requirements comparison script #295

Merged
merged 16 commits into from
Mar 21, 2024
Merged

Data requirements comparison script #295

merged 16 commits into from
Mar 21, 2024

Conversation

elsaperelli
Copy link
Contributor

Summary

Since we are reworking our data requirements calculation in fqm-execution, we have found a need for comparing our data requirements output to that of the elm-parser-for-ecqms, which we know to be a more accurate data requirements calculation.

New behavior

No need behavior within fqm-execution, just the addition of scripts for comparison and the /data-requirements directory that contains everything (structured similarly to the /regression directory).

Code changes

  • data-requirements/README.md - explains the purpose of the data-requirements directory and scripts and details instructions on how to run the scripts and how to interpret their outputs.
  • data-requirements/compare.sh - this script compares the overall outputs of the data requirements (similar to the regression script)
  • .gitignore - add some directories from /data-requirements
  • .gitkeep - add jan-2024-connectathon to keep an empty directory
  • data-requirements/fqm-e-dr.ts - helper file for calculating the data-requirements for all measures in jan-2024-connectathon using fqm-execution (used in both bash scripts)
  • data-requirements/summary-compare.sh - summary comparison bash script
  • data-requirements/summary-compare.ts - summary comparison helper file

Testing guidance

NOTE: I detail most of the necessary information in the /data-requirements/README.md so please let me know if there is anything missing in that file that would be helpful!

  • First, read through the README.md for running instructions and output descriptions.
  • Make sure to get the january-2024-connectathon files from me that we cannot check into this repository.
  • Make sure both of the scripts run and that their outputs make sense.
  • I am mainly looking for feedback on the readability and usability of these scripts. I spent potentially too much time on this task trying to figure out what outputs were the most helpful. In an effort to keep things moving, I want to get feedback on the current state. I am of the opinion that if there are any major suggestions (i.e. "We should output the comparison results to their own files!") that we should make a backlog task for them.

Copy link

github-actions bot commented Mar 6, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 85.47% 2377/2781
🟡 Branches 73.28% 2219/3028
🟢 Functions 88.15% 424/481
🟢 Lines 85.81% 2297/2677

Test suite run success

451 tests passing in 31 suites.

Report generated by 🧪jest coverage report action from 5ea2981

@hossenlopp hossenlopp self-requested a review March 6, 2024 17:19
@hossenlopp hossenlopp self-assigned this Mar 6, 2024
data-requirements/README.md Outdated Show resolved Hide resolved
data-requirements/README.md Show resolved Hide resolved
data-requirements/compare.sh Show resolved Hide resolved
data-requirements/summary-compare.sh Outdated Show resolved Hide resolved
@elsaperelli elsaperelli requested a review from lmd59 March 11, 2024 17:02
@elsaperelli elsaperelli force-pushed the dr-comparison-script branch from 9f73733 to 6ad518d Compare March 20, 2024 17:00
@elsaperelli elsaperelli requested a review from hossenlopp March 20, 2024 18:03
Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitkeep files get removed by runs, this could result in them accidentally being removed in a commit.

data-requirements/summary-compare.sh Outdated Show resolved Hide resolved
data-requirements/compare.sh Outdated Show resolved Hide resolved
@elsaperelli elsaperelli requested a review from hossenlopp March 21, 2024 12:53
@elsaperelli elsaperelli force-pushed the dr-comparison-script branch from f610b53 to 5ea2981 Compare March 21, 2024 16:06
@hossenlopp hossenlopp merged commit c50b66c into master Mar 21, 2024
6 checks passed
@hossenlopp hossenlopp deleted the dr-comparison-script branch March 21, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants