Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to inferno_core 0.5.1, add presets #51

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Conversation

elsaperelli
Copy link
Contributor

Summary

This PR upgrades this Inferno Test Kit for DEQM Measure Operations to use the latest version of inferno_core, inferno_core 0.5.1. It also makes any changes needed to run the test kit with Docker and locally. Adds presets for ease of testing.

New behavior

The user of this test kit can now use the preset feature in the upper left corner of the test kit in order to pre fill the test suite inputs. I added two presets: one for when the user runs the deqm-test-server with Docker and the other for running the deqm-test-server locally with npm start. Note: these presets just contain example inputs for ease of testing.

Code changes

  • .env.development/.env.production/.env.test/config/nginx.background.conf/config/nginx.conf/docker-compose.yml/docker-compose.background.yml - use hl7validator (part of inferno_core upgrade)
  • Gemfile.lock/deqm_test_kit.gemspec - upgrade inferno_core to 0.5.1
  • README.md - docker command changes, formatting
  • config/presets/deqm_test_server_docker_suite.json/config/presets/deqm_test_server_local_suite.json - two presets, one for running deqm-test-server with Docker with this test-kit, the other for running it locally
  • run.sh/setup.sh - docker compose instead of docker-compose

Testing guidance

WITH DOCKER:

  • In deqm-test-kit:
    • ./setup
    • docker compose pull
    • docker compose up --build
  • In Insomnia, execute the commands in the "Docker" Directory of the attached Insomnia request collection. This will populate the Docker instance of the deqm-test-server with the Measures and Libraries from the ColorectalCancerScreeningsFHIR bundle. Note: I made a task in the backlog to create a solution to populating the Docker instance of the deqm-test-server.
  • In the test kit at http://localhost:4567, use the DEQM Test Server Docker preset and run all of the tests.

LOCALLY:

  • In deqm-test-kit:
    • bundle install
    • ASYNC_JOBS=false bundle exec puma
    • Navigate to http://localhost:4567 for the test kit
  • In deqm-test-server:
    • npm run db:reset
    • npm run upload-bundles
    • npm start
  • In Insomia, execute the commands in the "Local" Directory of the attached Insomnia request collection.
  • In the test kit at http://localhost:4567, use the DEQM Test Server Local preset and run all of the tests.

deqm-test-kit.json

Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick comment on the dockerized validator changes.

@@ -17,14 +18,18 @@ services:
command: bundle exec sidekiq -r ./worker.rb
depends_on:
- redis
validator_service:
# validator_service:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to hold on to these commented out sections with the previous validator config?

image: infernocommunity/fhir-validator-app
depends_on:
- validator_service
# validator_service:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to hold on to these commented out sections with the previous validator config?

@elsaperelli elsaperelli removed the request for review from lmd59 December 5, 2024 14:12
@hossenlopp hossenlopp merged commit f5dbb13 into main Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants