update rubocop

.rubocop.yml

@@ -3,14 +3,39 @@ inherit_from: .rubocop_todo.yml
 AllCops:
   TargetRubyVersion: 2.3
 
+Layout/BlockAlignment:
+  Enabled: false
 Documentation:
   Enabled: false
 Style/DateTime:
   Enabled: false
-Performance/HashEachMethods:
-  Enabled: false
 Style/RedundantReturn:
   Enabled: false
 Style/WordArray:
   Enabled: false
-
+Style/ExpandPathArguments:
+  Enabled: false
+Layout/EmptyLineAfterGuardClause:
+  Enabled: false
+Style/MultipleComparison:
+  Enabled: false
+Layout/LeadingBlankLines:
+  Enabled: false
+Style/UnneededCondition:
+  Enabled: false
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+Lint/UnneededCopDisableDirective:
+  Enabled: false
+Performance/InefficientHashSearch:
+  Enabled: false
+Layout/AlignHash:
+  Exclude:
+    - 'test/unit/hqmf/model/nqf_0002_test.rb'
+    - 'lib/hqmf-model/data_criteria.rb'
+    - 'lib/measure-loader/vsac_value_set_loader.rb'
+    - 'lib/util/code_system_helper.rb'
+    - 'test/test_helper.rb'
+    - 'test/unit/hqmf/model/population_criteria_test.rb'

.rubocop_todo.yml

@@ -28,16 +28,6 @@ Layout/AlignArray:
   Exclude:
     - 'test/unit/hqmf/model/nqf_0002_test.rb'
 
-# Offense count: 51
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
-  Exclude:
-    - 'test/unit/hqmf/model/nqf_0002_test.rb'
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
@@ -407,7 +397,7 @@ Lint/DuplicateMethods:
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect.
 # SupportedStylesAlignWith: keyword, variable, start_of_line
-Lint/EndAlignment:
+Layout/EndAlignment:
   Exclude:
     - 'lib/hqmf-model/data_criteria.rb'
 
@@ -457,14 +447,6 @@ Lint/UnderscorePrefixedVariableName:
   Exclude:
     - 'lib/hqmf-parser/converter/pass1/data_criteria_converter.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
-Lint/UnneededDisable:
-  Exclude:
-    - 'lib/hqmf-parser/2.0/field_value_helper.rb'
-    - 'lib/hqmf-parser/2.0/value_set_helper.rb'
-    - 'lib/hqmf-parser/cql/value_set_helper.rb'
-
 # Offense count: 26
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.

Gemfile

@@ -9,7 +9,7 @@ gem 'mongoid', '> 6.0.5', '< 9.0.0'
 
 group :development, :test do
   gem 'bundler-audit'
-  gem 'rubocop', '~> 0.52.1', require: false
+  gem 'rubocop', '~> 0.63.0', require: false
   gem 'byebug'
   gem 'pry'
   gem 'pry-nav'
@@ -20,7 +20,7 @@ group :development do
 end
 
 group :test do
-  gem 'factory_girl', '> 4.1.0'
+  gem 'factory_bot'
   gem 'tailor', '~> 1.1.2'
   gem 'cane', '~> 2.3.0'
   gem 'codecov'

test/simplecov_init.rb

@@ -6,4 +6,4 @@
   track_files 'lib/**/*.rb'
 end
 
-SimpleCov.formatters = SimpleCov::Formatter::MultiFormatter.new([SimpleCov::Formatter::HTMLFormatter,SimpleCov::Formatter::Codecov])
+SimpleCov.formatters = SimpleCov::Formatter::MultiFormatter.new([SimpleCov::Formatter::HTMLFormatter,SimpleCov::Formatter::SimpleFormatter])

test/test_helper.rb

@@ -1,7 +1,7 @@
 require_relative './simplecov_init'
-require 'factory_girl'
+require 'factory_bot'
 require 'erubis'
-require 'active_support'
+require 'active_support/all'
 require 'mongoid'
 require 'mongoid/tree'
 require 'uuid'
@@ -23,7 +23,7 @@
 require 'bundler/setup'
 
 Mongoid.load!('config/mongoid.yml', :test)
-FactoryGirl.find_definitions
+FactoryBot.find_definitions
 
 class Minitest::Test
   extend Minitest::Spec::DSL