OR Multiple _typeFilters

[elsaperelli]

Summary

This PR ensures that our implementation of the _typeFilter $export Query Parameter aligns with the Bulk Data Access IG. Two or more _typeFilter Query Parameters are OR'd together when provided in an export request.

New behavior

• _typeFilter is now aligned with the IG: "When more than one _typeFilter parameter is provided with a query for the same resource type, the server SHALL include resources of that resource type that meet the criteria in any of the parameters (a logical "or")."

Code changes

• src/service/export.service.js - checks if _typeFilter is already an array
• src/util/exportToNDJson.js - checks if _typeFilter is already an array, added a TODO comment for addressing ANDs within a _typeFilter query (we have a separate backlog task for this)
• test/util/exportToNDJson.test.js - added unit test for _typeFilter array

Testing guidance

• npm run db:reset
• npm run upload-bundles
• npm start
• Try out different _typeFilter queries in Insomnia and make sure they work as expected! Example request collection for Insomnia is attached.

typeFilterUpdate.json

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	75.63%	574/759
🟡	Branches	63.33% (+0.14% 🔼)	209/330
🟡	Functions	75.83%	91/120
🟡	Lines	75.87%	566/746

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / export.service.js	85.91%	80% (-0.68% 🔻)	94.12%	85.52%

Test suite run success

96 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 9bbd0e0

[lmd59]

Suggested change

	// subqueries may be joined together with a comma for a logical "or"
	// subqueries may be joined together with a comma or as an array for a logical "or"

[lmd59]

(or however you think it would be appropriate to update this comment)

[lmd59]

Great updates! Added one very small recommendation for a comment update.