Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueSet export is Bad Request #49

Merged
merged 1 commit into from
Aug 9, 2024
Merged

ValueSet export is Bad Request #49

merged 1 commit into from
Aug 9, 2024

Conversation

lmd59
Copy link
Contributor

@lmd59 lmd59 commented Aug 7, 2024

Summary

Previously a system export with _type=ValueSet had an unexpected file read error. ValueSet should not be allowed to be exported, so

New behavior

Any export request with ValueSet as the type specified in the parameters gives a Bad Request response

Code changes

  • export.service update to exclude ValueSet from the types that are supported for export (but not from the types that are supported for storage in the collection creation script)
  • exportToNDJson change to properly create the full client id folder to prevent other issues like this

Testing guidance

  • npm run check
  • npm run start
  • Insomnia export requests such as $export?_typeFilter=ValueSet?id=test, $export?_elements=ValueSet.id, $export?_type=ValueSet should all return a 400 specifying ValueSet is unsupported.

Copy link

github-actions bot commented Aug 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.63% (+0.03% 🔼)
574/759
🟡 Branches 63.19% 206/326
🟡 Functions
75.83% (+0.2% 🔼)
91/120
🟡 Lines 75.87% 566/746

Test suite run success

95 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from 3273867

@elsaperelli elsaperelli self-requested a review August 9, 2024 14:56
@elsaperelli elsaperelli self-assigned this Aug 9, 2024
Copy link
Collaborator

@elsaperelli elsaperelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@elsaperelli elsaperelli merged commit 888020b into main Aug 9, 2024
4 checks passed
@elsaperelli elsaperelli deleted the vs-error branch August 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants