Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastify-cors #43

Merged
merged 3 commits into from
May 24, 2024
Merged

Add fastify-cors #43

merged 3 commits into from
May 24, 2024

Conversation

elsaperelli
Copy link
Collaborator

Summary

This PR bumps fastify to its latest version and adds fastify/cors as a dependency.

New behavior

Enables cors with fastify/cors.

Code changes

  • package.json/package-lock.json - bumps fastify and adds fastify/cors
  • src/server/app.js - adds cors
  • src/server/server.js - prettyPrint not allowed in latest fastify, .listen requires an options object in latest fastify

Testing guidance

  • npm run check
  • Do we want/need to be any more specific with cors?

Copy link

github-actions bot commented May 23, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.89% (+0.11% 🔼)
498/665
🟡 Branches 61.64% 180/292
🟡 Functions 72.64% 77/106
🟡 Lines
75.19% (+0.11% 🔼)
491/653

Test suite run success

78 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 8f6e696

@hossenlopp hossenlopp self-requested a review May 24, 2024 14:23
@hossenlopp hossenlopp self-assigned this May 24, 2024
@hossenlopp hossenlopp merged commit 806fcc6 into main May 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants