-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker setup for bulk export #41
Conversation
Coverage report
Show files with reduced coverage 🔻
Test suite run success76 tests passing in 7 suites. Report generated by 🧪jest coverage report action from ab5001f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing through things a bit more, but a couple of small initial suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the stuff in the docker-compose can be paired down and moved to the Dockerfile.
Suggest renaming PUBLIC_BULK_SERVER
to something that implies it is the base URL. Perhaps BULK_BASE_URL
.
We could also use a script for running and pushing the build like we have in measure-repository
service.
@hossenlopp I first misread your comment thinking you asked for a bundle upload script...but now we have both! Added a |
…ion. added image name to compose example. added prettierignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment/question. Otherwise I think it looks good!
Summary
This PR sets up a working Docker environment for this server and changes some things so that it can be run on our abacus-dev ECE.
New behavior
Server can be run with Docker! Also pushed this repository to docker hub and added it to abacus-dev.
Code changes
.env
- addsPUBLIC_BULK_SERVER
variable and changesPORT
to 3000 for consistency.env.test
- addsPUBLIC_BULK_SERVER
variableDockerfile
- upgrades node, addsENV HOST
andENV PORT
variablesdocker-compose.example.yml
- example docker-compose for future reference (similar to that in themeasure-repository
)docker-compose.yml
- add redis, upgrade mongo, addPUBLIC_BULK_SERVER
postTransactionBundles.js
/bulkstatus.service.js
/export.service.js
/bulkstatus.service.test.js
- usePUBLIC_BULK_SERVER
Testing guidance
npm run check
docker compose up --build