Fix update-requirement check to handle "no current snapshot" requirement properly #10064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent properly The current implementation of the `assert-ref-snapshot-id` update requirement neglects the `null` requirement case, which means "there must be no current snapshot". The fix is simple. Also added a check that the ref-name in that requirement-check is `main`. Also updated a few cases to eliminate IDE warnings in the same class. Fixes projectnessie#10062
adutra
reviewed
Dec 9, 2024
| @@ -702,6 +702,15 @@ interface SetSnapshotRef extends IcebergMetadataUpdate { | |||
|
|
|||
| @Override | |||
| default void applyToTable(IcebergTableMetadataUpdateState state) { | |||
| checkState( | |||
| "main".equals(refName()) && "branch".equals(type()), | |||
There was a problem hiding this comment.
Should this be hard-coded to main or set to the repository's default branch?
There was a problem hiding this comment.
This is "Iceberg's main" - not Nessie's default branch. (Confusing, yea...)
adutra
approved these changes
Dec 9, 2024
dimas-b
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
assert-ref-snapshot-idupdate requirement neglects thenullrequirement case, which means "there must be no current snapshot". The fix is simple. Also added a check that the ref-name in that requirement-check ismain.Also updated a few cases to eliminate IDE warnings in the same class.
Fixes #10062