Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move Matplotlib-specific Solara components to separate file #1943

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 7, 2024

Contains #1941, to avoid merge conflict. Depends on that PR to be merged first.

@rht rht force-pushed the solara_components branch from a78f802 to e814b68 Compare January 7, 2024 06:44
@rht rht changed the title refactor: Move Matplotlib-specific components to separate file refactor: Move Matplotlib-specific Solara components to separate file Jan 7, 2024
@rht rht force-pushed the solara_components branch 2 times, most recently from fdedb2c to 91b85a4 Compare January 7, 2024 06:58
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (d3a0e2f) 79.19% compared to head (a2750ea) 79.24%.
Report is 2 commits behind head on main.

Files Patch % Lines
mesa/experimental/components/matplotlib.py 13.18% 79 Missing ⚠️
mesa/experimental/jupyter_viz.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1943      +/-   ##
==========================================
+ Coverage   79.19%   79.24%   +0.04%     
==========================================
  Files          15       16       +1     
  Lines        1293     1296       +3     
  Branches      288      288              
==========================================
+ Hits         1024     1027       +3     
  Misses        230      230              
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rht rht force-pushed the solara_components branch from 91b85a4 to 908663a Compare January 7, 2024 22:31
@Corvince
Copy link
Contributor

Conflicts need to be resolved then its ready to merge

@rht rht force-pushed the solara_components branch from 908663a to a2750ea Compare January 15, 2024 22:24
@rht
Copy link
Contributor Author

rht commented Jan 15, 2024

Rebased.

@rht rht added the maintenance Release notes label label Jan 16, 2024
@rht rht merged commit 8cf7abd into projectmesa:main Jan 16, 2024
11 of 13 checks passed
@rht rht deleted the solara_components branch January 16, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants