Migrate from setuptools to hatch #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
=======================================
Coverage 79.92% 79.92%
=======================================
Files 15 15
Lines 1270 1270
Branches 277 277
=======================================
Hits 1015 1015
Misses 216 216
Partials 39 39 ☔ View full report in Codecov by Sentry. |
rht
force-pushed
the
hatch
branch
2 times, most recently
from
392e42e to
95bd4dc
Compare
|
Rebased. This PR is ready. |
|
Sorry this took so long, I always get nervous messing with the project management tools. I am good with this. It is faster and cleaner and as you said we can always switch to poetry if that becomes the standard. The only thing I would ask is can you add the badge to the readme --- |
With Hatch, files that are not tracked in VCS are automatically excluded.
|
Rebased, and the Hatch badge added. |
Corvince
approved these changes
Jan 10, 2024
|
I am merging this, I had good (albeit very small) experience with hatch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1870 to be merged.
Several resources recommended to replace setuptools with either Flit, Hatch, Poetry, or PDM. Both Flit and Hatch are maintained by PyPA. Flit is restricted to pure Python projects. According to pyOpenSci, PDM's documentation can be confusing, and has only 1 maintainer. That leaves Hatch and Poetry. There was a discussion about dropping Pipenv and instead support Poetry. I wasn't able to find the thread from the issue search. However, it should be fine to go from setuptools to Hatch first, because the jump is much smaller: the diff for pyproject.toml in this PR is <10 LOC.