Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename make_geospace_leaflet to make_geospace_component #270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wang-boyu
Copy link
Member

Addresses #262 -

  • add make_geospace_component for SolaraViz
  • add deprecation warning in make_geospace_leaflet

@wang-boyu wang-boyu added dependency Release notes label maintenance Release notes label labels Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.43%. Comparing base (ce501b6) to head (90e1104).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
...geo/visualization/components/geospace_component.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   78.21%   73.43%   -4.78%     
==========================================
  Files          10       10              
  Lines         693      862     +169     
  Branches      151      131      -20     
==========================================
+ Hits          542      633      +91     
- Misses        127      196      +69     
- Partials       24       33       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wang-boyu wang-boyu mentioned this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Release notes label maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant