Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update make_plot_measure method name from mesa viz #264

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

wang-boyu
Copy link
Member

@wang-boyu wang-boyu commented Nov 24, 2024

make_plot_measure gets renamed to make_plot_component in Mesa visualization module, and it is failing our RTD build. This PR simply updates it to the new method name.

Also remove the old scheduler in intro tutorial and use agentset instead.

@wang-boyu wang-boyu added the maintenance Release notes label label Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (ce501b6) to head (ca59672).
Report is 62 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   78.21%   73.54%   -4.67%     
==========================================
  Files          10       10              
  Lines         693      858     +165     
  Branches      151      131      -20     
==========================================
+ Hits          542      631      +89     
- Misses        127      194      +67     
- Partials       24       33       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@wang-boyu wang-boyu requested review from quaquel and tpike3 November 24, 2024 02:00
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@wang-boyu wang-boyu merged commit fd0af55 into projectmesa:main Nov 24, 2024
12 of 13 checks passed
@wang-boyu
Copy link
Member Author

Thanks for reviewing!

@wang-boyu wang-boyu deleted the fix/mesa-viz-import branch November 24, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants