add model parameter in RasterLayer class method

[wang-boyu]

Fix #236 as mentioned in #236 (comment)

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.32%. Comparing base (ce501b6) to head (488c1cf).
Report is 64 commits behind head on main.

Files with missing lines	Patch %	Lines
mesa_geo/raster_layers.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
+ Coverage   78.21%   78.32%   +0.11%     
==========================================
  Files          10        9       -1     
  Lines         693      766      +73     
  Branches      151      173      +22     
==========================================
+ Hits          542      600      +58     
- Misses        127      131       +4     
- Partials       24       35      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[EwoutH]

Thanks for the fix. Could you check against one of the examples if this fixes the issue? I can remember doing something like this but it still not working out.

[wang-boyu]

It's a bit difficult to test - we removed old visualization in #212. When latest mesa-geo is installed, gis example throws errors for visualization module.

If I remove all visualizations in the rainfall example and add some print statements in RasterLayer's constructor, this is what I get before this fix:

RasterLayer.__init__
width: 285, height: 143, crs: None, total_bounds: [-122.26638888878, 42.855833333, -121.94972222209202, 43.01472222189958]
model: <class 'rainfall.space.LakeCell'>, cell_cls: <class 'mesa_geo.raster_layers.Cell'>

and after this fix (also need to fix the example by adding self.model when creating raster layer from file):

RasterLayer.__init__
width: 285, height: 143, crs: None, total_bounds: [-122.26638888878, 42.855833333, -121.94972222209202, 43.01472222189958]
model: <rainfall.model.Rainfall object at 0x12239a7e0>, cell_cls: <class 'rainfall.space.LakeCell'>

[EwoutH]

Thanks. We can merge first and see if it’s sufficient to update the examples.