Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conf.py to fix build #226

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Update conf.py to fix build #226

merged 3 commits into from
Aug 18, 2024

Conversation

tpike3
Copy link
Member

@tpike3 tpike3 commented Aug 16, 2024

image

tpike3 added 3 commits August 16, 2024 15:24
Updates nbsphinx so it does not try to use local kernel; instead uses readthedocs kernel
Fix Build

Updates nbsphinx so it does not try to use local kernel; instead uses readthedocs kernel
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (ce501b6) to head (6c2a8db).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   78.21%   78.30%   +0.08%     
==========================================
  Files          10        9       -1     
  Lines         693      765      +72     
  Branches      151      173      +22     
==========================================
+ Hits          542      599      +57     
- Misses        127      131       +4     
- Partials       24       35      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EwoutH
Copy link
Member

EwoutH commented Aug 17, 2024

I would really like Read the docs on PRs to be enabled on Mesa-geo to validate that these PRs solve the issue.

CC @wang-boyu

@EwoutH EwoutH added the ignore-for-release PRs that aren't included in the release notes label Aug 18, 2024
@EwoutH EwoutH merged commit c761c93 into projectmesa:main Aug 18, 2024
11 checks passed
@EwoutH
Copy link
Member

EwoutH commented Aug 18, 2024

I hoped that it would trigger a build when pushed to the main branch, but it doesn't look like it did.

We really need @wang-boyu for this.

@wang-boyu wang-boyu added this to the 0.8.0 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release PRs that aren't included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants