Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial and viz #217

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Update tutorial and viz #217

merged 1 commit into from
Aug 14, 2024

Conversation

tpike3
Copy link
Member

@tpike3 tpike3 commented Aug 13, 2024

  • Update tutorial to be SIR model
  • Update Viz to allow for different markers; default agent to circle -Update tests
  • Update tests

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.30%. Comparing base (ce501b6) to head (ac37dd9).
Report is 30 commits behind head on main.

Files Patch % Lines
mesa_geo/visualization/leaflet_viz.py 53.33% 5 Missing and 2 partials ⚠️
mesa_geo/visualization/geojupyter_viz.py 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   78.21%   78.30%   +0.08%     
==========================================
  Files          10        9       -1     
  Lines         693      765      +72     
  Branches      151      173      +22     
==========================================
+ Hits          542      599      +57     
- Misses        127      131       +4     
- Partials       24       35      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Update tutorial to be SIR model
- Update Viz to allow for different markers; default agent to circle
-Update tests
@wang-boyu wang-boyu self-requested a review August 14, 2024 02:52
@wang-boyu wang-boyu added the enhancement Release notes label label Aug 14, 2024
@wang-boyu
Copy link
Member

Tutorial and tests can be run successfully. @rht @EwoutH would you like to take a look at this PR too?

@rht
Copy link
Contributor

rht commented Aug 14, 2024

What is missing is to rename JupyterViz to SolaraViz.

@rht rht merged commit 4bd9c80 into projectmesa:main Aug 14, 2024
9 of 10 checks passed
@EwoutH
Copy link
Member

EwoutH commented Aug 14, 2024

Maybe add a short "What you will learn" section at the beginning. Otherwise looks good!

@EwoutH EwoutH added this to the 0.8.0 milestone Aug 14, 2024
@EwoutH EwoutH added breaking Release notes label and removed breaking Release notes label labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants