Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mesa-geo to sync with mesa >=2.3.0 #211

Closed
wants to merge 2 commits into from

Conversation

tpike3
Copy link
Member

@tpike3 tpike3 commented Jul 2, 2024

  • update to geoagent, tile_layers,raster_layers pass in mesa.Model so compatible with AgentSets
  • update visualization to use solara with Jupyter_viz and leaflet_viz
  • remove js visualization
  • update tests

tpike3 added 2 commits July 2, 2024 05:35
-update to geoagen, tile_layers,raster_layers pass in mesa.Model so compatable with AgentSets
-update visualization to use solara with Jupyter_viz and leaflet_viz
-remove js visualization
-update tests
 - update to geoagent, tile_layers,raster_layers pass in mesa.Model so compatible with AgentSets
- update visualization to use solara with Jupyter_viz and leaflet_viz
- remove js visualization
- update tests
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 30.63063% with 77 lines in your changes missing coverage. Please review.

Project coverage is 71.22%. Comparing base (ce501b6) to head (62e0653).
Report is 8 commits behind head on main.

Files Patch % Lines
mesa_geo/visualization/geojupyter_viz.py 16.88% 64 Missing ⚠️
mesa_geo/visualization/leaflet_viz.py 50.00% 11 Missing ⚠️
mesa_geo/geoagent.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   78.21%   71.22%   -6.99%     
==========================================
  Files          10        9       -1     
  Lines         693      768      +75     
  Branches      151      175      +24     
==========================================
+ Hits          542      547       +5     
- Misses        127      192      +65     
- Partials       24       29       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpike3 tpike3 requested review from wang-boyu and rht July 2, 2024 10:11
@rht
Copy link
Contributor

rht commented Jul 2, 2024

Since the code is functional anyway, rather than having this in PR limbo due to the blocker being lots of boilerplate code, I'd rather approve this and then refactor later.

@jackiekazil jackiekazil self-requested a review July 2, 2024 12:41
Copy link
Member

@jackiekazil jackiekazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackiekazil
Copy link
Member

I am okay with this being merged after conflicts are resolved.

@tpike3
Copy link
Member Author

tpike3 commented Jul 3, 2024

Apologies, I need to close this an reopen to fix the history conflicts so it can be merged.

@tpike3 tpike3 closed this Jul 3, 2024
@EwoutH
Copy link
Member

EwoutH commented Jul 3, 2024

Thanks for this effort!

On a bit wider note, I am (still) a proponent of moving towards a monorepo. See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants