Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pre-commit and ga workflows to be consistent with mesa #181

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

wang-boyu
Copy link
Member

@wang-boyu wang-boyu added this to the v0.7.0 milestone Jan 5, 2024
@wang-boyu wang-boyu marked this pull request as ready for review January 5, 2024 01:28
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f9f7d6a) 78.14% compared to head (110b6c0) 78.14%.

Files Patch % Lines
mesa_geo/geoagent.py 50.00% 1 Missing ⚠️
mesa_geo/raster_layers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files          10       10           
  Lines         691      691           
  Branches      151      151           
=======================================
  Hits          540      540           
  Misses        127      127           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wang-boyu wang-boyu force-pushed the ci/pre-commit-and-ga branch from e1b0338 to 72b817c Compare January 5, 2024 01:30
@wang-boyu wang-boyu force-pushed the ci/pre-commit-and-ga branch from 72b817c to 110b6c0 Compare January 5, 2024 01:39
@wang-boyu
Copy link
Member Author

The failing check is about code coverage, and it should be fine to be ignored for this PR.

@Corvince
Copy link
Contributor

Corvince commented Jan 5, 2024

Looks good. I think we should revisit some workflows, but this should be done in mesa and we can continue to follow mesa with mesa-geo.

I'll set up the pypi integration with release on tag so we can truly close #171

@Corvince Corvince merged commit f134528 into projectmesa:main Jan 5, 2024
13 of 14 checks passed
@wang-boyu
Copy link
Member Author

Thanks!

@wang-boyu wang-boyu deleted the ci/pre-commit-and-ga branch January 5, 2024 13:35
@wang-boyu wang-boyu added the ci Release notes label label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: run on all pushes and PRs, publish to PyPI on tags
2 participants