Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update solaraviz function names #237

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

wang-boyu
Copy link
Member

  • Update function names:
    • make_plot_measure to make_plot_component
    • make_space_matplotlib to make_space_component
  • Move conways_game_of_life_fast example back into examples folder

@wang-boyu wang-boyu added the bug label Dec 1, 2024
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Assuming you've validated that the visualisation now performs as expected, good to go.

@wang-boyu
Copy link
Member Author

Thanks for the approvals. If there are other issues in gis examples, we can submit additional PRs. This PR is mainly about fixing function names.

Merging now.

@wang-boyu wang-boyu merged commit 0c93dc5 into projectmesa:main Dec 12, 2024
5 checks passed
@wang-boyu wang-boyu deleted the fix/viz-function-name branch December 12, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants