Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gis: update three examples to use solara viz #226

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

wang-boyu
Copy link
Member

This PR updates the remaining three gis examples to use Solara viz, partly addressing #154. It depends on projectmesa/mesa-geo#254 to be released, as these examples use raster layers.

Also made some small adjustments in ordering components to account for the grid layout, instead of the previous column layout in Solara viz.

Failed tests in agents_and_networks example should be fixed by projectmesa/mesa#2368.

@wang-boyu wang-boyu added the gis label Oct 15, 2024
@wang-boyu wang-boyu requested review from rht and EwoutH October 15, 2024 22:25
Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks voor working on this!

It depends on projectmesa/mesa-geo#254 to be released

I think we can release a new pre-release right now, right? Do you need any help with that?

@wang-boyu
Copy link
Member Author

Yes! A new pre-release would be great. Would you like to make one? Or else I could find some time to do it too.

@EwoutH
Copy link
Member

EwoutH commented Oct 17, 2024

I published v0.9.0 alpha 1: https://github.com/projectmesa/mesa-geo/releases/tag/v0.9.0a1

@wang-boyu wang-boyu marked this pull request as ready for review October 17, 2024 13:58
@wang-boyu
Copy link
Member Author

Thanks @EwoutH! Appreciate it. This PR is ready now.

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this, looks great!

@EwoutH EwoutH merged commit 5655bac into projectmesa:main Oct 17, 2024
1 of 3 checks passed
wang-boyu added a commit to wang-boyu/mesa-examples that referenced this pull request Oct 17, 2024
This PR updates the remaining three gis examples to use Solara viz, partly addressing projectmesa#154. It depends on projectmesa/mesa-geo#254 to be released, as these examples use raster layers.

Also made some small adjustments in ordering components to account for the grid layout, instead of the previous column layout in Solara viz.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants