bug fix and code simplification in hotelling #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
EwoutH
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Awesome, appreciated, and really clean!
That all_cells.select_random_cell() is just such a handy construct to have!
Maybe we can even add random_cell and random_empty_cell properties to the spaces, so that you don't have to go via all_cells (just an idea, other PR of course).
Yes having it on the grid would be easy (as would be a method for drawing 1 cells with replacement and without replacement - Both can probably be added to `CellCollection first). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up from #198