Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly request host byte order in pcmcat #947

Open
wants to merge 1 commit into
base: testing
Choose a base branch
from

Conversation

argilo
Copy link
Contributor

@argilo argilo commented Nov 27, 2024

As noted in ka9q/ka9q-radio#66, ka9q-radio recently changed pcmcat's behaviour with respect to network-to-host byte order conversions.

Previously, a network-to-host byte order conversion was always performed by default, and could be turned off with the -b flag.

Now, network-to-host byte order conversion only occurs by default for two specific RTP types (both having a sample rate of 44100, which Auto-RX does not use), and the -b argument takes a parameter: -b 0 turns off network-to-host byte order conversion, while -b 1 turns it on.

Because of the change to the -b argument, it would be impractical for Auto-RX to support both behaviours. Since Auto-RX expects samples in host byte order, explicitly requesting that with -b 1 seems wise, even if it means dropping support for older versions of ka9q-radio.

If this change is adopted, we'll need to update the wiki to recommend commit 541c15849cbe59694770ca1b2bbad1835ad3667f of ka9q-radio. I think it's worth moving forward to this commit, since it includes several bug fixes:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant