Explicitly request host byte order in pcmcat #947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in ka9q/ka9q-radio#66, ka9q-radio recently changed pcmcat's behaviour with respect to network-to-host byte order conversions.
Previously, a network-to-host byte order conversion was always performed by default, and could be turned off with the
-b
flag.Now, network-to-host byte order conversion only occurs by default for two specific RTP types (both having a sample rate of 44100, which Auto-RX does not use), and the
-b
argument takes a parameter:-b 0
turns off network-to-host byte order conversion, while-b 1
turns it on.Because of the change to the
-b
argument, it would be impractical for Auto-RX to support both behaviours. Since Auto-RX expects samples in host byte order, explicitly requesting that with-b 1
seems wise, even if it means dropping support for older versions of ka9q-radio.If this change is adopted, we'll need to update the wiki to recommend commit 541c15849cbe59694770ca1b2bbad1835ad3667f of ka9q-radio. I think it's worth moving forward to this commit, since it includes several bug fixes: